phet commented on code in PR #3904:
URL: https://github.com/apache/gobblin/pull/3904#discussion_r1542145641
##########
gobblin-service/src/main/java/org/apache/gobblin/service/modules/orchestration/LeaseAttemptStatus.java:
##########
@@ -24,10 +24,10 @@
import lombok.Getter;
-/*
- Class used to encapsulate status of lease acquisition attempt and derivations
should contain information specific to
- the status that results. The #getDagAction and
#getMinimumLingerDurationMillis are meant to be overriden and used by
- relevant derived classes.
+/**
+ Class used to encapsulate status of lease acquisition attempts made by {@link
MultiActiveLeaseArbiter} and contains
+ information specific to the status that results. The #getDagAction and
#getMinimumLingerDurationMillis are meant to be
Review Comment:
this is where to use `{@link ...}` syntax:
```
#getDagAction and #getMinimumLingerDurationMillis
```
##########
gobblin-service/src/main/java/org/apache/gobblin/service/monitoring/DagManagementDagActionStoreChangeMonitor.java:
##########
@@ -52,7 +52,7 @@ public DagManagementDagActionStoreChangeMonitor(Config
config, int numThreads,
}
/**
- * This implementation passes on the {@link DagActionStore.DagAction} to the
+ * This implementation passes on {@link DagActionStore.DagAction} to the
Review Comment:
"This implementation passes on *the* {@link DagActionStore.DagAction} to
-t-h-e- {@link DagManagement} instead..."
(strike `-t-h-e-`)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
