phet commented on code in PR #3899:
URL: https://github.com/apache/gobblin/pull/3899#discussion_r1544687018
##########
gobblin-service/src/test/java/org/apache/gobblin/service/modules/orchestration/DagManagementTaskStreamImplTest.java:
##########
@@ -88,7 +87,7 @@ public void setUp() throws Exception {
/* This tests adding and removal of dag actions from dag task stream with a
launch task. It verifies that the
{@link DagManagementTaskStreamImpl#next()} call blocks until a {@link
LeaseAttemptStatus.LeaseObtainedStatus} is
returned for a particular action.
- TODO: when we have different dag procs in future, update this test to add
other types of actions (and tasks)
+ TODO: when we have different dag procs in the future, update this test to
add other types of actions (and tasks)
Review Comment:
the alternative would be to make `DMTSImpl::getDagTask`
`@VisibleForTesting`, then to exercise it with each `DagAction`.
that would seem to better streamline the validation we're really after
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
