arjun4084346 commented on code in PR #3899:
URL: https://github.com/apache/gobblin/pull/3899#discussion_r1544767114


##########
gobblin-service/src/main/java/org/apache/gobblin/service/monitoring/DagActionStoreChangeMonitor.java:
##########
@@ -180,6 +180,7 @@ protected void processMessage(DecodeableKafkaRecord 
message) {
     String flowGroup = value.getFlowGroup();
     String flowName = value.getFlowName();
     String flowExecutionId = value.getFlowExecutionId();
+    String jobName = value.getJobName();

Review Comment:
   will it give error if we do not change the table?
   should we have a try/catch so it does not fail when expecting old/new 
schema? it should work in case of rollback's (due to any unrelated problem), 
the rollback should not require to roll back the table change and accept both 
old/new schemas



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to