[
https://issues.apache.org/jira/browse/GOBBLIN-2033?focusedWorklogId=912886&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-912886
]
ASF GitHub Bot logged work on GOBBLIN-2033:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 03/Apr/24 17:39
Start Date: 03/Apr/24 17:39
Worklog Time Spent: 10m
Work Description: rongshen commented on code in PR #3910:
URL: https://github.com/apache/gobblin/pull/3910#discussion_r1550192483
##########
gobblin-core-base/src/main/java/org/apache/gobblin/source/extractor/extract/FlushingExtractor.java:
##########
@@ -129,6 +134,21 @@ public FlushingExtractor(WorkUnitState state) {
initFlushPublisher();
MetricContextUtils.registerGauge(this.getMetricContext(),
WATERMARK_COMMIT_TIME_METRIC, this.watermarkCommitTime);
initCommitStepMetrics(this.preCommitSteps, this.postCommitSteps);
+
+ if (state.getPropAsBoolean(WRITER_OUTPUT_DIR_UPDATE_ENABLED, false)) {
Review Comment:
change the if condition to the suggested way on throwing exceptions
Issue Time Tracking
-------------------
Worklog Id: (was: 912886)
Time Spent: 20m (was: 10m)
> Append HelixInstanceName to task runner staging paths
> -----------------------------------------------------
>
> Key: GOBBLIN-2033
> URL: https://issues.apache.org/jira/browse/GOBBLIN-2033
> Project: Apache Gobblin
> Issue Type: Improvement
> Reporter: Matthew Ho
> Priority: Major
> Time Spent: 20m
> Remaining Estimate: 0h
>
> During the shutdown of a task runner, it's possible to write bad files to the
> staging area. On startup of a new task runner, it should not try to reuse
> that old file.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
