[ 
https://issues.apache.org/jira/browse/GOBBLIN-2033?focusedWorklogId=912885&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-912885
 ]

ASF GitHub Bot logged work on GOBBLIN-2033:
-------------------------------------------

                Author: ASF GitHub Bot
            Created on: 03/Apr/24 17:39
            Start Date: 03/Apr/24 17:39
    Worklog Time Spent: 10m 
      Work Description: rongshen commented on code in PR #3910:
URL: https://github.com/apache/gobblin/pull/3910#discussion_r1550191571


##########
gobblin-core-base/src/main/java/org/apache/gobblin/source/extractor/extract/FlushingExtractor.java:
##########
@@ -88,6 +90,9 @@ public abstract class FlushingExtractor<S, D> extends 
EventBasedExtractor<S, D>
   public static final String WATERMARK_COMMIT_TIME_METRIC = 
"state.store.metrics.watermarkCommitTime";
   public static final String COMMIT_STEP_METRIC_PREFIX = "commit.step.";
 
+  public static final String WRITER_OUTPUT_DIR_UPDATE_ENABLED =

Review Comment:
   changed config name to ENABLE_UNIQUE_WRITER_OUTPUT_DIR_WITH_TASK_ATTEMPT_ID, 
as well as included a comment block for the config





Issue Time Tracking
-------------------

            Worklog Id:     (was: 912885)
    Remaining Estimate: 0h
            Time Spent: 10m

> Append HelixInstanceName to task runner staging paths
> -----------------------------------------------------
>
>                 Key: GOBBLIN-2033
>                 URL: https://issues.apache.org/jira/browse/GOBBLIN-2033
>             Project: Apache Gobblin
>          Issue Type: Improvement
>            Reporter: Matthew Ho
>            Priority: Major
>          Time Spent: 10m
>  Remaining Estimate: 0h
>
> During the shutdown of a task runner, it's possible to write bad files to the 
> staging area. On startup of a new task runner, it should not try to reuse 
> that old file.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to