phet commented on code in PR #3911:
URL: https://github.com/apache/gobblin/pull/3911#discussion_r1550515929
##########
gobblin-yarn/src/main/java/org/apache/gobblin/yarn/GobblinYarnAppLauncher.java:
##########
@@ -269,7 +269,8 @@ public GobblinYarnAppLauncher(Config config,
YarnConfiguration yarnConfiguration
Optional.of(config.getString(GobblinYarnConfigurationKeys.APP_MASTER_JVM_ARGS_KEY))
:
Optional.<String>absent();
- this.sinkLogRootDir = new
Path(config.getString(GobblinYarnConfigurationKeys.LOGS_SINK_ROOT_DIR_KEY));
+ this.sinkLogRootDir =
config.hasPath(GobblinYarnConfigurationKeys.LOGS_SINK_ROOT_DIR_KEY) ?
+ new
Path(config.getString(GobblinYarnConfigurationKeys.LOGS_SINK_ROOT_DIR_KEY)) :
null;
Review Comment:
couldn't this be `ConfigUtils.getString(theKey, null)`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
