Will-Lo commented on code in PR #3911:
URL: https://github.com/apache/gobblin/pull/3911#discussion_r1556382308
##########
gobblin-yarn/src/main/java/org/apache/gobblin/yarn/GobblinYarnAppLauncher.java:
##########
@@ -204,7 +204,7 @@ public class GobblinYarnAppLauncher {
private final Optional<String> appMasterJvmArgs;
- private final Path sinkLogRootDir;
+ private final String sinkLogRootDir;
Review Comment:
Nope because we create a new Path using this string, but omit creating the
path if it's null.
https://github.com/apache/gobblin/blob/b08ad65948deedc00c94e828ba5a76c9578cb93c/gobblin-yarn/src/main/java/org/apache/gobblin/yarn/GobblinYarnAppLauncher.java#L379
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
