[
https://issues.apache.org/jira/browse/GOBBLIN-2036?focusedWorklogId=912934&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-912934
]
ASF GitHub Bot logged work on GOBBLIN-2036:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 04/Apr/24 01:02
Start Date: 04/Apr/24 01:02
Worklog Time Spent: 10m
Work Description: Will-Lo opened a new pull request, #3915:
URL: https://github.com/apache/gobblin/pull/3915
Dear Gobblin maintainers,
Please accept this PR. I understand that it will not be reviewed until I
have checked off all the steps below!
### JIRA
- [x] My PR addresses the following [Gobblin
JIRA](https://issues.apache.org/jira/browse/GOBBLIN/) issues and references
them in the PR title. For example, "[GOBBLIN-XXX] My Gobblin PR"
- https://issues.apache.org/jira/browse/GOBBLIN-2036
### Description
- [x] Here are some details about my PR, including screenshots (if
applicable):
The old value of `flow.allowConcurrentExecution` is set as a string value in
the flow configuration jsons, but in the code we parse it as boolean. Instead
we want to parse as string then convert to boolean to make this backwards
compatible with existing flow configs.
### Tests
- [ ] My PR adds the following unit tests __OR__ does not need testing for
this extremely good reason:
### Commits
- [x] My commits all reference JIRA issues in their subject lines, and I
have squashed multiple commits if they address the same issue. In addition, my
commits follow the guidelines from "[How to write a good git commit
message](http://chris.beams.io/posts/git-commit/)":
1. Subject is separated from body by a blank line
2. Subject is limited to 50 characters
3. Subject does not end with a period
4. Subject uses the imperative mood ("add", not "adding")
5. Body wraps at 72 characters
6. Body explains "what" and "why", not "how"
Issue Time Tracking
-------------------
Worklog Id: (was: 912934)
Remaining Estimate: 0h
Time Spent: 10m
> Fix bug where concurrent flow config key is parsed as boolean instead of
> fetched as string
> ------------------------------------------------------------------------------------------
>
> Key: GOBBLIN-2036
> URL: https://issues.apache.org/jira/browse/GOBBLIN-2036
> Project: Apache Gobblin
> Issue Type: Bug
> Reporter: William Lo
> Priority: Major
> Time Spent: 10m
> Remaining Estimate: 0h
>
> The old value ofÂ
> {code:java}
> flow.allowConcurrentExecution{code}
> is set as a string value in the flow configuration jsons, but in the code we
> parse it as boolean. Instead we want to parse as string then convert to
> boolean to make this backwards compatible with existing flow configs.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
