[jira] [Work logged] (GOBBLIN-2036) Fix bug where concurrent flow config key is parsed as boolean instead of fetched as string

[ASF GitHub Bot (Jira)]

     [ 
https://issues.apache.org/jira/browse/GOBBLIN-2036?focusedWorklogId=912940&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-912940
 ]

ASF GitHub Bot logged work on GOBBLIN-2036:
-------------------------------------------

                Author: ASF GitHub Bot
            Created on: 04/Apr/24 01:20
            Start Date: 04/Apr/24 01:20
    Worklog Time Spent: 10m 
      Work Description: codecov-commenter commented on PR #3915:
URL: https://github.com/apache/gobblin/pull/3915#issuecomment-2035913700

   ## 
[Codecov](https://app.codecov.io/gh/apache/gobblin/pull/3915?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
 Report
   All modified and coverable lines are covered by tests :white_check_mark:
   > Project coverage is 48.39%. Comparing base 
[(`1fe2958`)](https://app.codecov.io/gh/apache/gobblin/commit/1fe2958791dfe64b2494178324d9411695639bcd?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
 to head 
[(`fbd7ef4`)](https://app.codecov.io/gh/apache/gobblin/pull/3915?dropdown=coverage&src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
   
   
   <details><summary>Additional details and impacted files</summary>
   
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #3915      +/-   ##
   ============================================
   + Coverage     46.64%   48.39%   +1.74%     
   + Complexity    11222     9629    -1593     
   ============================================
     Files          2244     1856     -388     
     Lines         88367    72415   -15952     
     Branches       9679     8102    -1577     
   ============================================
   - Hits          41221    35043    -6178     
   + Misses        43430    34152    -9278     
   + Partials       3716     3220     -496     
   ```
   
   
   
   </details>
   
   [:umbrella: View full report in Codecov by 
Sentry](https://app.codecov.io/gh/apache/gobblin/pull/3915?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
   
   :loudspeaker: Have feedback on the report? [Share it 
here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
   




Issue Time Tracking
-------------------

    Worklog Id:     (was: 912940)
    Time Spent: 20m  (was: 10m)

> Fix bug where concurrent flow config key is parsed as boolean instead of 
> fetched as string
> ------------------------------------------------------------------------------------------
>
>                 Key: GOBBLIN-2036
>                 URL: https://issues.apache.org/jira/browse/GOBBLIN-2036
>             Project: Apache Gobblin
>          Issue Type: Bug
>            Reporter: William Lo
>            Priority: Major
>          Time Spent: 20m
>  Remaining Estimate: 0h
>
> The old value of 
> {code:java}
> flow.allowConcurrentExecution{code}
> is set as a string value in the flow configuration jsons, but in the code we 
> parse it as boolean. Instead we want to parse as string then convert to 
> boolean to make this backwards compatible with existing flow configs.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)