[
https://issues.apache.org/jira/browse/GOBBLIN-2037?focusedWorklogId=913271&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-913271
]
ASF GitHub Bot logged work on GOBBLIN-2037:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 05/Apr/24 21:04
Start Date: 05/Apr/24 21:04
Worklog Time Spent: 10m
Work Description: umustafi opened a new pull request, #3916:
URL: https://github.com/apache/gobblin/pull/3916
Dear Gobblin maintainers,
Please accept this PR. I understand that it will not be reviewed until I
have checked off all the steps below!
### JIRA
- [X] My PR addresses the following [Gobblin
JIRA](https://issues.apache.org/jira/browse/GOBBLIN/) issues and references
them in the PR title. For example, "[GOBBLIN-XXX] My Gobblin PR"
- https://issues.apache.org/jira/browse/GOBBLIN-2037
### Description
- [X] Here are some details about my PR, including screenshots (if
applicable):
The DagActionStoreChangeMonitor cannot be started before the Flowgraph,
DagManager, and SpecCompiler are up and running. When the monitor is
initialized by Guice, it was previously also starting to load dagActions from
the store immediately to compile and process. There is a race condition created
where the actions can be loaded too quickly from the store and passed to the
specCompiler before it's ready. The SpecCompiler hangs waiting for the
flowGraph to load, causing startup to fail.
The solution is the bind the monitor in Guice but only enable processing of
actions after the GobblinServiceManager ensures other classes are ready to be
called by the DagActionStoreChangeMonitor.
### Tests
- [X] My PR adds the following unit tests __OR__ does not need testing for
this extremely good reason:
Test a local deployment
### Commits
- [X] My commits all reference JIRA issues in their subject lines, and I
have squashed multiple commits if they address the same issue. In addition, my
commits follow the guidelines from "[How to write a good git commit
message](http://chris.beams.io/posts/git-commit/)":
1. Subject is separated from body by a blank line
2. Subject is limited to 50 characters
3. Subject does not end with a period
4. Subject uses the imperative mood ("add", not "adding")
5. Body wraps at 72 characters
6. Body explains "what" and "why", not "how"
Issue Time Tracking
-------------------
Worklog Id: (was: 913271)
Remaining Estimate: 0h
Time Spent: 10m
> Start DagActionMonitor functionality after its Dependencies
> -----------------------------------------------------------
>
> Key: GOBBLIN-2037
> URL: https://issues.apache.org/jira/browse/GOBBLIN-2037
> Project: Apache Gobblin
> Issue Type: Bug
> Components: gobblin-service
> Reporter: Urmi Mustafi
> Assignee: Abhishek Tiwari
> Priority: Major
> Time Spent: 10m
> Remaining Estimate: 0h
>
> The {{DagActionStoreChangeMonitor}} cannot be started before the Flowgraph,
> DagManager, and SpecCompiler are up and running. When the monitor is
> initialized by Guice, it was previously also starting to load dagActions from
> the store immediately to compile and process. There is a race condition
> created where the actions can be loaded too quickly from the store and passed
> to the specCompiler before it's ready. The SpecCompiler hangs waiting for the
> flowGraph to load, causing startup to fail.
> The solution is the bind the monitor in Guice but only enable processing of
> actions after the GobblinServiceManager ensures other classes are ready to be
> called by the DagActionStoreChangeMonitor.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
