[
https://issues.apache.org/jira/browse/GOBBLIN-2037?focusedWorklogId=913275&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-913275
]
ASF GitHub Bot logged work on GOBBLIN-2037:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 05/Apr/24 21:27
Start Date: 05/Apr/24 21:27
Worklog Time Spent: 10m
Work Description: arjun4084346 commented on code in PR #3916:
URL: https://github.com/apache/gobblin/pull/3916#discussion_r1554314470
##########
gobblin-service/src/main/java/org/apache/gobblin/service/monitoring/DagActionStoreChangeMonitorFactory.java:
##########
@@ -74,7 +74,6 @@ private DagActionStoreChangeMonitor
createDagActionStoreMonitor() {
@Override
public DagActionStoreChangeMonitor get() {
DagActionStoreChangeMonitor changeMonitor = createDagActionStoreMonitor();
- changeMonitor.initializeMonitor();
Review Comment:
Can you please also change DagManagementDagActionStoreChangeMonitorFactory
Issue Time Tracking
-------------------
Worklog Id: (was: 913275)
Time Spent: 40m (was: 0.5h)
> Start DagActionMonitor functionality after its Dependencies
> -----------------------------------------------------------
>
> Key: GOBBLIN-2037
> URL: https://issues.apache.org/jira/browse/GOBBLIN-2037
> Project: Apache Gobblin
> Issue Type: Bug
> Components: gobblin-service
> Reporter: Urmi Mustafi
> Assignee: Abhishek Tiwari
> Priority: Major
> Time Spent: 40m
> Remaining Estimate: 0h
>
> The {{DagActionStoreChangeMonitor}} cannot be started before the Flowgraph,
> DagManager, and SpecCompiler are up and running. When the monitor is
> initialized by Guice, it was previously also starting to load dagActions from
> the store immediately to compile and process. There is a race condition
> created where the actions can be loaded too quickly from the store and passed
> to the specCompiler before it's ready. The SpecCompiler hangs waiting for the
> flowGraph to load, causing startup to fail.
> The solution is the bind the monitor in Guice but only enable processing of
> actions after the GobblinServiceManager ensures other classes are ready to be
> called by the DagActionStoreChangeMonitor.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
