[
https://issues.apache.org/jira/browse/GOBBLIN-2045?focusedWorklogId=915146&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-915146
]
ASF GitHub Bot logged work on GOBBLIN-2045:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 17/Apr/24 16:00
Start Date: 17/Apr/24 16:00
Worklog Time Spent: 10m
Work Description: Will-Lo commented on code in PR #3924:
URL: https://github.com/apache/gobblin/pull/3924#discussion_r1569091797
##########
gobblin-temporal/src/main/java/org/apache/gobblin/temporal/ddm/work/assistance/Help.java:
##########
@@ -247,4 +251,32 @@ protected static void
doGaaSFlowExecutionContextPropagation(String flowGroup, St
MDC.put(ConfigurationKeys.FLOW_NAME_KEY,
String.format("%s:%s",ConfigurationKeys.FLOW_NAME_KEY, flowName));
MDC.put(ConfigurationKeys.FLOW_EXECUTION_ID_KEY,
String.format("%s:%s",ConfigurationKeys.FLOW_EXECUTION_ID_KEY, flowExecId));
}
+
+ /**
+ * refine {@link AutomaticTroubleshooter} issues then report them to the
{@link EventSubmitter} and log an issues summary via `logger`;
+ * gracefully handle `null` `troubleshooter`
+ */
+ public static void finalizeTroubleshooting(AutomaticTroubleshooter
troubleshooter, EventSubmitter eventSubmitter, Logger logger, String
correlator) {
+ try {
+ if (troubleshooter == null) {
+ logger.warn("{} - No troubleshooter to report issues from automatic
troubleshooter", correlator);
Review Comment:
Should this be a warn or info log? It would be testing against our own impl
but from a user perspective no issues should be a good thing
Issue Time Tracking
-------------------
Worklog Id: (was: 915146)
Time Spent: 20m (was: 10m)
> Integrate `AutomaticTroubleshooter` with gobblin-on-temporal
> `GenerateWorkUnitsImpl`
> ------------------------------------------------------------------------------------
>
> Key: GOBBLIN-2045
> URL: https://issues.apache.org/jira/browse/GOBBLIN-2045
> Project: Apache Gobblin
> Issue Type: New Feature
> Components: gobblin-core
> Reporter: Kip Kohn
> Assignee: Abhishek Tiwari
> Priority: Major
> Time Spent: 20m
> Remaining Estimate: 0h
>
> the `AutomaticTroubleshooter`'s only integration with gobblin-on-temporal is
> during "Work Processing", in `ProcessWorkUnitImpl`. that misses any issues
> arising during "Work Discovery". to include those, integrate the
> `AutomaticTroubleshooter` with `GenerateWorkUnitsImpl`
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
