[
https://issues.apache.org/jira/browse/GOBBLIN-2045?focusedWorklogId=915148&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-915148
]
ASF GitHub Bot logged work on GOBBLIN-2045:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 17/Apr/24 16:04
Start Date: 17/Apr/24 16:04
Worklog Time Spent: 10m
Work Description: phet commented on code in PR #3924:
URL: https://github.com/apache/gobblin/pull/3924#discussion_r1569095939
##########
gobblin-temporal/src/main/java/org/apache/gobblin/temporal/ddm/work/assistance/Help.java:
##########
@@ -247,4 +251,32 @@ protected static void
doGaaSFlowExecutionContextPropagation(String flowGroup, St
MDC.put(ConfigurationKeys.FLOW_NAME_KEY,
String.format("%s:%s",ConfigurationKeys.FLOW_NAME_KEY, flowName));
MDC.put(ConfigurationKeys.FLOW_EXECUTION_ID_KEY,
String.format("%s:%s",ConfigurationKeys.FLOW_EXECUTION_ID_KEY, flowExecId));
}
+
+ /**
+ * refine {@link AutomaticTroubleshooter} issues then report them to the
{@link EventSubmitter} and log an issues summary via `logger`;
+ * gracefully handle `null` `troubleshooter`
+ */
+ public static void finalizeTroubleshooting(AutomaticTroubleshooter
troubleshooter, EventSubmitter eventSubmitter, Logger logger, String
correlator) {
+ try {
+ if (troubleshooter == null) {
+ logger.warn("{} - No troubleshooter to report issues from automatic
troubleshooter", correlator);
Review Comment:
agreed on that! but this here is warning that the troubleshooter was never
initialized. hence there may or may not have been issues, but in either case
no reporting would happen. this calls out loudly that "no news" isn't
necessarily "good news"
Issue Time Tracking
-------------------
Worklog Id: (was: 915148)
Time Spent: 40m (was: 0.5h)
> Integrate `AutomaticTroubleshooter` with gobblin-on-temporal
> `GenerateWorkUnitsImpl`
> ------------------------------------------------------------------------------------
>
> Key: GOBBLIN-2045
> URL: https://issues.apache.org/jira/browse/GOBBLIN-2045
> Project: Apache Gobblin
> Issue Type: New Feature
> Components: gobblin-core
> Reporter: Kip Kohn
> Assignee: Abhishek Tiwari
> Priority: Major
> Time Spent: 40m
> Remaining Estimate: 0h
>
> the `AutomaticTroubleshooter`'s only integration with gobblin-on-temporal is
> during "Work Processing", in `ProcessWorkUnitImpl`. that misses any issues
> arising during "Work Discovery". to include those, integrate the
> `AutomaticTroubleshooter` with `GenerateWorkUnitsImpl`
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
