[
https://issues.apache.org/jira/browse/GOBBLIN-2056?focusedWorklogId=916932&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-916932
]
ASF GitHub Bot logged work on GOBBLIN-2056:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 30/Apr/24 00:25
Start Date: 30/Apr/24 00:25
Worklog Time Spent: 10m
Work Description: umustafi commented on code in PR #3937:
URL: https://github.com/apache/gobblin/pull/3937#discussion_r1583972758
##########
gobblin-service/src/main/java/org/apache/gobblin/service/modules/utils/FlowCompilationValidationHelper.java:
##########
@@ -73,12 +74,12 @@ public class FlowCompilationValidationHelper {
@Inject
public FlowCompilationValidationHelper(Config config,
SharedFlowMetricsSingleton sharedFlowMetricsSingleton,
- UserQuotaManager userQuotaManager, FlowStatusGenerator
flowStatusGenerator) {
Review Comment:
how do we know the `topologySpecFactory` has been initialized by now?
##########
gobblin-service/src/main/java/org/apache/gobblin/service/modules/flow/BaseFlowToJobSpecCompiler.java:
##########
@@ -97,35 +97,13 @@ public abstract class BaseFlowToJobSpecCompiler implements
SpecCompiler {
private Optional<UserQuotaManager> userQuotaManager;
- public BaseFlowToJobSpecCompiler(Config config){
- this(config,true);
- }
-
- public BaseFlowToJobSpecCompiler(Config config, boolean
instrumentationEnabled){
- this(config, Optional.<Logger>absent(), true);
- }
-
- public BaseFlowToJobSpecCompiler(Config config, Optional<Logger> log){
- this(config, log,true);
- }
-
- public BaseFlowToJobSpecCompiler(Config config, Optional<Logger> log,
boolean instrumentationEnabled){
- this.log = log.isPresent() ? log.get() :
LoggerFactory.getLogger(getClass());
- if (instrumentationEnabled) {
Review Comment:
Arjun did some refactoring before which made instrumentation required I
believe. Can you link that change to explain what's happening here?
Issue Time Tracking
-------------------
Worklog Id: (was: 916932)
Time Spent: 20m (was: 10m)
> initialize topology specs directly from the configs
> ---------------------------------------------------
>
> Key: GOBBLIN-2056
> URL: https://issues.apache.org/jira/browse/GOBBLIN-2056
> Project: Apache Gobblin
> Issue Type: Improvement
> Reporter: Arjun Singh Bora
> Priority: Major
> Time Spent: 20m
> Remaining Estimate: 0h
>
> initialize topology specs directly from the configs instead of waiting for
> the callbacks of topology spec catalog listerners
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
