[
https://issues.apache.org/jira/browse/GOBBLIN-2056?focusedWorklogId=917101&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-917101
]
ASF GitHub Bot logged work on GOBBLIN-2056:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 01/May/24 06:12
Start Date: 01/May/24 06:12
Worklog Time Spent: 10m
Work Description: arjun4084346 commented on code in PR #3937:
URL: https://github.com/apache/gobblin/pull/3937#discussion_r1585928379
##########
gobblin-service/src/main/java/org/apache/gobblin/service/modules/flow/BaseFlowToJobSpecCompiler.java:
##########
@@ -97,35 +97,13 @@ public abstract class BaseFlowToJobSpecCompiler implements
SpecCompiler {
private Optional<UserQuotaManager> userQuotaManager;
- public BaseFlowToJobSpecCompiler(Config config){
- this(config,true);
- }
-
- public BaseFlowToJobSpecCompiler(Config config, boolean
instrumentationEnabled){
- this(config, Optional.<Logger>absent(), true);
- }
-
- public BaseFlowToJobSpecCompiler(Config config, Optional<Logger> log){
- this(config, log,true);
- }
-
- public BaseFlowToJobSpecCompiler(Config config, Optional<Logger> log,
boolean instrumentationEnabled){
- this.log = log.isPresent() ? log.get() :
LoggerFactory.getLogger(getClass());
- if (instrumentationEnabled) {
Review Comment:
1) yes, in https://github.com/apache/gobblin/pull/3855/files I made some
optional fields mandatory. instrumentationEnabled was not one of them, but
eventSubmitter was which is related.
2) instrumentationEnabled is usually true in prod, these variables are set
false only for doing easier tests.
3) Also, in this particular case, instrumentationEnabled was hard coded to
`true` in the above above constructor anyway.
Issue Time Tracking
-------------------
Worklog Id: (was: 917101)
Time Spent: 0.5h (was: 20m)
> initialize topology specs directly from the configs
> ---------------------------------------------------
>
> Key: GOBBLIN-2056
> URL: https://issues.apache.org/jira/browse/GOBBLIN-2056
> Project: Apache Gobblin
> Issue Type: Improvement
> Reporter: Arjun Singh Bora
> Priority: Major
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> initialize topology specs directly from the configs instead of waiting for
> the callbacks of topology spec catalog listerners
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
