[
https://issues.apache.org/jira/browse/GOBBLIN-2056?focusedWorklogId=917163&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-917163
]
ASF GitHub Bot logged work on GOBBLIN-2056:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 01/May/24 19:28
Start Date: 01/May/24 19:28
Worklog Time Spent: 10m
Work Description: arjun4084346 commented on code in PR #3937:
URL: https://github.com/apache/gobblin/pull/3937#discussion_r1586719870
##########
gobblin-service/src/main/java/org/apache/gobblin/service/modules/flow/BaseFlowToJobSpecCompiler.java:
##########
@@ -219,8 +199,6 @@ private AddSpecResponse onAddFlowSpec(FlowSpec flowSpec) {
public AddSpecResponse onAddSpec(Spec addedSpec) {
if (addedSpec instanceof FlowSpec) {
return onAddFlowSpec((FlowSpec) addedSpec);
- } else if (addedSpec instanceof TopologySpec) {
- return onAddTopologySpec( (TopologySpec) addedSpec);
Review Comment:
being a TS listener feels of no use to me. There should be no TS listener in
gaas.
Issue Time Tracking
-------------------
Worklog Id: (was: 917163)
Time Spent: 2h 10m (was: 2h)
> initialize topology specs directly from the configs
> ---------------------------------------------------
>
> Key: GOBBLIN-2056
> URL: https://issues.apache.org/jira/browse/GOBBLIN-2056
> Project: Apache Gobblin
> Issue Type: Improvement
> Reporter: Arjun Singh Bora
> Priority: Major
> Time Spent: 2h 10m
> Remaining Estimate: 0h
>
> initialize topology specs directly from the configs instead of waiting for
> the callbacks of topology spec catalog listerners
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
