phet commented on code in PR #3940:
URL: https://github.com/apache/gobblin/pull/3940#discussion_r1591556813
##########
gobblin-service/src/main/java/org/apache/gobblin/service/monitoring/GaaSObservabilityEventProducer.java:
##########
Review Comment:
naming-wise, do you foresee this class to handle both the job and flow
observability events? if not, and only the job ones, suggest to rename the
class
##########
CHANGELOG.md:
##########
Review Comment:
do you want global search-and-replace even to apply to past changes?
##########
gobblin-metrics-libs/gobblin-metrics-base/src/main/avro/GaaSObservabilityEventExperimental.avsc:
##########
@@ -127,7 +127,7 @@
{
"name": "executorId",
"type": "string",
- "doc": "The ID of the spec executor that ran or would have ran the job",
+ "doc": "The ID of the spec executor that ran or would have run the job",
Review Comment:
fine to correct here, but really we want it on L142 of the *other* schema
file
##########
gobblin-metrics-libs/gobblin-metrics-base/src/main/avro/GaaSObservabilityEventExperimental.avsc:
##########
@@ -112,7 +112,7 @@
"null",
"string"
],
- "doc": "User URN (if applicable) that runs the underlying Gobblin job",
+ "doc": "User URN (if applicable) that runs the underlying Gobblin job
e.g. Hadoop headless account",
Review Comment:
suggest to leave out
##########
CHANGELOG.md:
##########
Review Comment:
do you want global search-and-replace even to apply to past changelog?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
