phet commented on code in PR #3940:
URL: https://github.com/apache/gobblin/pull/3940#discussion_r1591587381
##########
gobblin-service/src/test/java/org/apache/gobblin/service/monitoring/GaaSObservabilityProducerTest.java:
##########
@@ -112,9 +118,9 @@ public void
testCreateGaaSObservabilityEventWithFullMetadata() throws Exception
Assert.assertEquals(event.getJobStatus(), JobStatus.SUCCEEDED);
Assert.assertEquals(event.getExecutorUrl(), "hostName");
Assert.assertEquals(event.getIssues().size(), 1);
- Assert.assertEquals(event.getFlowEdgeId(), "flowEdge");
+ Assert.assertEquals(event.getFlowEdgeId(),
"sourceNode_destinationNode_flowEdge");
Review Comment:
don't we want this to be merely `flowEdge` (since we've already separately
tunneled `sourceNode` and `destinationNode`)?
(I realize you're merely checking what you inserted just above... more I
want to ensure the real events emitted actually have solely the flow edge ID as
a stand-alone string)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
