phet commented on code in PR #3944:
URL: https://github.com/apache/gobblin/pull/3944#discussion_r1593229683
##########
gobblin-service/src/test/java/org/apache/gobblin/service/modules/orchestration/OrchestratorTest.java:
##########
@@ -81,12 +84,15 @@ public class OrchestratorTest {
private FlowCatalog flowCatalog;
private FlowSpec flowSpec;
- private Orchestrator orchestrator;
+
+ private FlowStatusGenerator mockFlowStatusGenerator;
+ private DagManager mockDagManager;
+ private Orchestrator dagMgrNotFlowLaunchHandlerBasedOrchestrator;
private static final String TEST_USER = "testUser";
private static final String TEST_PASSWORD = "testPassword";
private static final String TEST_TABLE = "quotas";
- @BeforeClass
+ @BeforeMethod
Review Comment:
interesting pt. of comparison: after the [PR
check](https://github.com/apache/gobblin/actions/runs/8974993667/job/24692732545?pr=3944)
test failures gave:
```
java.io.IOException: Failure creation table TestDagStateStore
```
due to:
```
java.sql.SQLNonTransientConnectionException: Too many connections
```
I realized the `ITestMetastoreDatabase` needed to be closed.
I first put `.close()` within `@AfterMethod` and the 7 `OrchestratorTest`
cases took 1m49s. I then defined an `@AfterClass` for `.close()` and the same
7 tests (all passing in both definitions) took only 33s. hence, sticking w/
`@BeforeClass` + `@AfterClass` for that one.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
