phet commented on code in PR #3944:
URL: https://github.com/apache/gobblin/pull/3944#discussion_r1594463833
##########
gobblin-service/src/main/java/org/apache/gobblin/service/modules/orchestration/LeaseAttemptStatus.java:
##########
@@ -57,6 +58,8 @@ public static class NoLongerLeasingStatus extends
LeaseAttemptStatus {}
current LeaseObtainedStatus via the completeLease method from a caller
without access to the {@link MultiActiveLeaseArbiter}.
*/
@Data
+ // avoid - warning: Generating equals/hashCode implementation but without a
call to superclass, even though this class does not extend java.lang.Object
Review Comment:
warnings at least don't indicate that it's necessary over there and I
believe that's because warning arose since `LeaseObtainedStatus` and
`LeasedToAnotherStatus` are `@Data`, whereas `NoLongerLeasingStatus` is not.
since not `@Data`, lombok is not synthesizing `equals` for
`NoLongerLeasingStatus`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
