phet commented on code in PR #3938:
URL: https://github.com/apache/gobblin/pull/3938#discussion_r1596100187
##########
gobblin-service/src/main/java/org/apache/gobblin/service/modules/orchestration/proc/ResumeDagProc.java:
##########
@@ -82,12 +82,14 @@ protected void act(DagManagementStateStore
dagManagementStateStore, Optional<Dag
Map<String, String> jobMetadata =
TimingEventUtils.getJobMetadata(Maps.newHashMap(), node.getValue());
eventSubmitter.getTimingEvent(TimingEvent.LauncherTimings.JOB_PENDING_RESUME).stop(jobMetadata);
}
- // Set flowStartTime so that flow SLA will be based on current time
instead of original flow
+ // Set flowStartTime so that flow start deadline and flow completion
deadline will be based on current time instead of original flow
node.getValue().setFlowStartTime(flowResumeTime);
}
+ // these two statements effectively move the dag from failed dag store to
(running) dag store
Review Comment:
check for whether we do find a failed dag, but the same one is also in the
dag state store (so presumably a prior exec had failed between line 90 and 91)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
