phet commented on code in PR #3938:
URL: https://github.com/apache/gobblin/pull/3938#discussion_r1597013555
##########
gobblin-service/src/test/java/org/apache/gobblin/service/modules/orchestration/proc/ResumeDagProcTest.java:
##########
@@ -100,9 +102,17 @@ public void resumeDag()
resumeDagProc.process(this.dagManagementStateStore);
SpecProducer<Spec> specProducer =
DagManagerUtils.getSpecProducer(dag.getNodes().get(1));
+ List<SpecProducer<Spec>> otherSpecProducers =
dag.getNodes().stream().map(node -> {
+ try {
+ return DagManagerUtils.getSpecProducer(node);
+ } catch (ExecutionException | InterruptedException e) {
+ throw new RuntimeException(e);
+ }
+ }).filter(sp -> specProducer != sp).collect(Collectors.toList());
int expectedNumOfResumedJobs = 1; // = number of resumed nodes
Mockito.verify(specProducer,
Mockito.times(expectedNumOfResumedJobs)).addSpec(any());
Mockito.verify(this.dagManagementStateStore,
Mockito.times(expectedNumOfResumedJobs)).addDagNodeState(any(), any());
+ otherSpecProducers.forEach(sp -> Mockito.verify(sp,
Mockito.times(0)).addSpec(any()));
Review Comment:
nit: `Mockito.never()`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
