[
https://issues.apache.org/jira/browse/GOBBLIN-2057?focusedWorklogId=918644&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-918644
]
ASF GitHub Bot logged work on GOBBLIN-2057:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 09/May/24 23:38
Start Date: 09/May/24 23:38
Worklog Time Spent: 10m
Work Description: phet commented on code in PR #3938:
URL: https://github.com/apache/gobblin/pull/3938#discussion_r1596100187
##########
gobblin-service/src/main/java/org/apache/gobblin/service/modules/orchestration/proc/ResumeDagProc.java:
##########
@@ -82,12 +82,14 @@ protected void act(DagManagementStateStore
dagManagementStateStore, Optional<Dag
Map<String, String> jobMetadata =
TimingEventUtils.getJobMetadata(Maps.newHashMap(), node.getValue());
eventSubmitter.getTimingEvent(TimingEvent.LauncherTimings.JOB_PENDING_RESUME).stop(jobMetadata);
}
- // Set flowStartTime so that flow SLA will be based on current time
instead of original flow
+ // Set flowStartTime so that flow start deadline and flow completion
deadline will be based on current time instead of original flow
node.getValue().setFlowStartTime(flowResumeTime);
}
+ // these two statements effectively move the dag from failed dag store to
(running) dag store
Review Comment:
check for whether we do find a failed dag, but the same one is also in the
dag state store (so presumably a prior exec had failed between line 90 and 91)
Issue Time Tracking
-------------------
Worklog Id: (was: 918644)
Time Spent: 2.5h (was: 2h 20m)
> create resume dag proc
> ----------------------
>
> Key: GOBBLIN-2057
> URL: https://issues.apache.org/jira/browse/GOBBLIN-2057
> Project: Apache Gobblin
> Issue Type: Improvement
> Reporter: Arjun Singh Bora
> Priority: Major
> Time Spent: 2.5h
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
