[jira] [Work logged] (GOBBLIN-2057) create resume dag proc

[ASF GitHub Bot (Jira)]

     [ 
https://issues.apache.org/jira/browse/GOBBLIN-2057?focusedWorklogId=918828&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-918828
 ]

ASF GitHub Bot logged work on GOBBLIN-2057:
-------------------------------------------

                Author: ASF GitHub Bot
            Created on: 10/May/24 17:15
            Start Date: 10/May/24 17:15
    Worklog Time Spent: 10m 
      Work Description: phet commented on code in PR #3938:
URL: https://github.com/apache/gobblin/pull/3938#discussion_r1597013555


##########
gobblin-service/src/test/java/org/apache/gobblin/service/modules/orchestration/proc/ResumeDagProcTest.java:
##########
@@ -100,9 +102,17 @@ public void resumeDag()
     resumeDagProc.process(this.dagManagementStateStore);
 
     SpecProducer<Spec> specProducer = 
DagManagerUtils.getSpecProducer(dag.getNodes().get(1));
+    List<SpecProducer<Spec>> otherSpecProducers = 
dag.getNodes().stream().map(node -> {
+      try {
+        return DagManagerUtils.getSpecProducer(node);
+      } catch (ExecutionException | InterruptedException e) {
+        throw new RuntimeException(e);
+      }
+    }).filter(sp -> specProducer != sp).collect(Collectors.toList());
     int expectedNumOfResumedJobs = 1; // = number of resumed nodes
 
     Mockito.verify(specProducer, 
Mockito.times(expectedNumOfResumedJobs)).addSpec(any());
     Mockito.verify(this.dagManagementStateStore, 
Mockito.times(expectedNumOfResumedJobs)).addDagNodeState(any(), any());
+    otherSpecProducers.forEach(sp -> Mockito.verify(sp, 
Mockito.times(0)).addSpec(any()));

Review Comment:
   nit: `Mockito.never()`





Issue Time Tracking
-------------------

    Worklog Id:     (was: 918828)
    Time Spent: 3h 10m  (was: 3h)

> create resume dag proc
> ----------------------
>
>                 Key: GOBBLIN-2057
>                 URL: https://issues.apache.org/jira/browse/GOBBLIN-2057
>             Project: Apache Gobblin
>          Issue Type: Improvement
>            Reporter: Arjun Singh Bora
>            Priority: Major
>          Time Spent: 3h 10m
>  Remaining Estimate: 0h
>




--
This message was sent by Atlassian Jira
(v8.20.10#820010)