[
https://issues.apache.org/jira/browse/GOBBLIN-2070?focusedWorklogId=920148&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-920148
]
ASF GitHub Bot logged work on GOBBLIN-2070:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 21/May/24 04:59
Start Date: 21/May/24 04:59
Worklog Time Spent: 10m
Work Description: arjun4084346 commented on code in PR #3951:
URL: https://github.com/apache/gobblin/pull/3951#discussion_r1607631032
##########
gobblin-service/src/main/java/org/apache/gobblin/service/modules/orchestration/LeaseAttemptStatus.java:
##########
@@ -51,26 +51,23 @@ public long getMinimumLingerDurationMillis() {
public static class NoLongerLeasingStatus extends LeaseAttemptStatus {}
/*
- The participant calling this method acquired the lease for the event in
question. `Dag action`'s flow execution id
- is the timestamp associated with the lease and the time the caller obtained
the lease is stored within the
- `leaseAcquisitionTimestamp` field. The `multiActiveLeaseArbiter` reference
is used to recordLeaseSuccess for the
- current LeaseObtainedStatus via the completeLease method from a caller
without access to the {@link MultiActiveLeaseArbiter}.
+ The participant calling this method acquired the lease for the event in
question.
+ The timestamp associated with the lease is stored in `eventTimeMillis` field
and the time the caller obtained the
+ lease is stored within the`leaseAcquisitionTimestamp` field. Note that the
`Dag action` returned by the lease
+ arbitration attempt will be unchanged for flows that do not adopt the
consensus eventTimeMillis as the flow execution
+ id, so a separate field must be maintained the track the eventTimeMillis
for lease completion. The
Review Comment:
* maintained to track
Issue Time Tracking
-------------------
Worklog Id: (was: 920148)
Time Spent: 20m (was: 10m)
> Add eventTimestamp field to LeaseAttemptStatus for use in adhoc flow lease
> completion
> -------------------------------------------------------------------------------------
>
> Key: GOBBLIN-2070
> URL: https://issues.apache.org/jira/browse/GOBBLIN-2070
> Project: Apache Gobblin
> Issue Type: Bug
> Components: gobblin-service
> Reporter: Urmi Mustafi
> Assignee: Abhishek Tiwari
> Priority: Major
> Time Spent: 20m
> Remaining Estimate: 0h
>
> We are using the {{flowExecutionId}} from a {{LeaseObtainedStatus}} as the
> {{eventTimestamp}} to attempt to complete the lease at a later time. However,
> this only works for scheduled flows where we adopt the {{consensus
> eventTimestamp}} as the {{{}flowExecutionId{}}}. For adhoc flows, we do not
> update the id and the two values may be different so lease completion fails
> by the current owner of the lease. This PR keeps track of the
> {{eventTimestamp}} from the lease arbiter to prevent any confusion.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
