[
https://issues.apache.org/jira/browse/GOBBLIN-2070?focusedWorklogId=920273&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-920273
]
ASF GitHub Bot logged work on GOBBLIN-2070:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 21/May/24 16:58
Start Date: 21/May/24 16:58
Worklog Time Spent: 10m
Work Description: codecov-commenter commented on PR #3951:
URL: https://github.com/apache/gobblin/pull/3951#issuecomment-2123056646
##
[Codecov](https://app.codecov.io/gh/apache/gobblin/pull/3951?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
Report
All modified and coverable lines are covered by tests :white_check_mark:
> Project coverage is 38.69%. Comparing base
[(`1ca4944`)](https://app.codecov.io/gh/apache/gobblin/commit/1ca4944359fae3a7348a56427a2c38555811e977?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
to head
[(`04ac7e1`)](https://app.codecov.io/gh/apache/gobblin/pull/3951?dropdown=coverage&src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
> Report is 29 commits behind head on master.
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #3951 +/- ##
============================================
- Coverage 46.63% 38.69% -7.94%
+ Complexity 11247 1595 -9652
============================================
Files 2248 388 -1860
Lines 88520 15957 -72563
Branches 9701 1579 -8122
============================================
- Hits 41278 6174 -35104
+ Misses 43510 9289 -34221
+ Partials 3732 494 -3238
```
</details>
[:umbrella: View full report in Codecov by
Sentry](https://app.codecov.io/gh/apache/gobblin/pull/3951?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it
here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
Issue Time Tracking
-------------------
Worklog Id: (was: 920273)
Time Spent: 0.5h (was: 20m)
> Add eventTimestamp field to LeaseAttemptStatus for use in adhoc flow lease
> completion
> -------------------------------------------------------------------------------------
>
> Key: GOBBLIN-2070
> URL: https://issues.apache.org/jira/browse/GOBBLIN-2070
> Project: Apache Gobblin
> Issue Type: Bug
> Components: gobblin-service
> Reporter: Urmi Mustafi
> Assignee: Abhishek Tiwari
> Priority: Major
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> We are using the {{flowExecutionId}} from a {{LeaseObtainedStatus}} as the
> {{eventTimestamp}} to attempt to complete the lease at a later time. However,
> this only works for scheduled flows where we adopt the {{consensus
> eventTimestamp}} as the {{{}flowExecutionId{}}}. For adhoc flows, we do not
> update the id and the two values may be different so lease completion fails
> by the current owner of the lease. This PR keeps track of the
> {{eventTimestamp}} from the lease arbiter to prevent any confusion.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
