[
https://issues.apache.org/jira/browse/GOBBLIN-2072?focusedWorklogId=921122&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-921122
]
ASF GitHub Bot logged work on GOBBLIN-2072:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 28/May/24 20:25
Start Date: 28/May/24 20:25
Worklog Time Spent: 10m
Work Description: Will-Lo opened a new pull request, #3955:
URL: https://github.com/apache/gobblin/pull/3955
…t in setpermissionstep
Dear Gobblin maintainers,
Please accept this PR. I understand that it will not be reviewed until I
have checked off all the steps below!
### JIRA
- [ ] My PR addresses the following [Gobblin
JIRA](https://issues.apache.org/jira/browse/GOBBLIN/) issues and references
them in the PR title. For example, "[GOBBLIN-XXX] My Gobblin PR"
- https://issues.apache.org/jira/browse/GOBBLIN-XXX
### Description
- [ ] Here are some details about my PR, including screenshots (if
applicable):
In Manifest distcp, empty folders are being set with the incorrect
permissions in SetPermissionStep after being correctly set in the
CopyDataPublisher.
The suspected reason is that the empty child folders themselves are being
treated as ancestors, and this causes the permission checking of the source and
destination ancestors to act incorrectly.
In the long run, we should consolidate our permission comparison and logic
given that there are a multitude of different implementations and they each
seem to have their own quirks.
Correct CopyDataPublisher logs:
```
Setting destination directory hdfs://cluster/a/b/c owner and permission to
rwxr-x---
```
Incorrect SetPermissionCommitStep logs:
```
Setting permission rwxr-xr-x on path /a/b/c
```
### Tests
- [ ] My PR adds the following unit tests __OR__ does not need testing for
this extremely good reason:
### Commits
- [ ] My commits all reference JIRA issues in their subject lines, and I
have squashed multiple commits if they address the same issue. In addition, my
commits follow the guidelines from "[How to write a good git commit
message](http://chris.beams.io/posts/git-commit/)":
1. Subject is separated from body by a blank line
2. Subject is limited to 50 characters
3. Subject does not end with a period
4. Subject uses the imperative mood ("add", not "adding")
5. Body wraps at 72 characters
6. Body explains "what" and "why", not "how"
Issue Time Tracking
-------------------
Worklog Id: (was: 921122)
Remaining Estimate: 0h
Time Spent: 10m
> Permission mismatch in manifest distcp where empty folders are copied
> ---------------------------------------------------------------------
>
> Key: GOBBLIN-2072
> URL: https://issues.apache.org/jira/browse/GOBBLIN-2072
> Project: Apache Gobblin
> Issue Type: Bug
> Components: gobblin-core
> Reporter: William Lo
> Assignee: Abhishek Tiwari
> Priority: Minor
> Time Spent: 10m
> Remaining Estimate: 0h
>
> In Manifest distcp, empty folders are being set with the incorrect
> permissions in SetPermissionStep after being correctly set in the
> CopyDataPublisher.
> The suspected reason is that the folders themselves are being treated as
> ancestors, and this causes the permission checking of the source and
> destination ancestors to act incorrectly. TODO: We should consolidate our
> permission comparison and logic given that there are a multitude of different
> implementations and they each seem to have their own quirks.
> Correct CopyDataPublisher:
> {code:java}
> Setting destination directory hdfs://cluster/a/b/c owner and permission to
> rwxr-x---{code}
> Incorrect permission commit step:
> {code:java}
> [Azkaban] Setting permission rwxr-xr-x on path /a/b/c{code}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
