[
https://issues.apache.org/jira/browse/GOBBLIN-2072?focusedWorklogId=921592&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-921592
]
ASF GitHub Bot logged work on GOBBLIN-2072:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 31/May/24 21:22
Start Date: 31/May/24 21:22
Worklog Time Spent: 10m
Work Description: Will-Lo commented on code in PR #3955:
URL: https://github.com/apache/gobblin/pull/3955#discussion_r1622960617
##########
gobblin-data-management/src/main/java/org/apache/gobblin/data/management/copy/ManifestBasedDataset.java:
##########
@@ -132,7 +132,8 @@ public Iterator<FileSet<CopyEntity>>
getFileSetIterator(FileSystem targetFs, Cop
copyableFile.setFsDatasets(srcFs, targetFs);
copyEntities.add(copyableFile);
- Path fromPath = srcFs.getFileStatus(fileToCopy).isDirectory() ?
fileToCopy : fileToCopy.getParent();
+ // Always grab the parent since the above permission setting
should be setting the permission for a folder itself
+ Path fromPath = fileToCopy.getParent();
Review Comment:
It's null, I handled it in the tests
Issue Time Tracking
-------------------
Worklog Id: (was: 921592)
Time Spent: 1h (was: 50m)
> Permission mismatch in manifest distcp where empty folders are copied
> ---------------------------------------------------------------------
>
> Key: GOBBLIN-2072
> URL: https://issues.apache.org/jira/browse/GOBBLIN-2072
> Project: Apache Gobblin
> Issue Type: Bug
> Components: gobblin-core
> Reporter: William Lo
> Assignee: Abhishek Tiwari
> Priority: Minor
> Time Spent: 1h
> Remaining Estimate: 0h
>
> In Manifest distcp, empty folders are being set with the incorrect
> permissions in SetPermissionStep after being correctly set in the
> CopyDataPublisher.
> The suspected reason is that the folders themselves are being treated as
> ancestors, and this causes the permission checking of the source and
> destination ancestors to act incorrectly. TODO: We should consolidate our
> permission comparison and logic given that there are a multitude of different
> implementations and they each seem to have their own quirks.
> Correct CopyDataPublisher:
> {code:java}
> Setting destination directory hdfs://cluster/a/b/c owner and permission to
> rwxr-x---{code}
> Incorrect permission commit step:
> {code:java}
> [Azkaban] Setting permission rwxr-xr-x on path /a/b/c{code}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
