phet commented on code in PR #3960:
URL: https://github.com/apache/gobblin/pull/3960#discussion_r1622990585
##########
gobblin-service/src/main/java/org/apache/gobblin/service/modules/orchestration/proc/LaunchDagProc.java:
##########
@@ -102,6 +103,8 @@ private void submitNextNodes(DagManagementStateStore
dagManagementStateStore, Da
DagProcUtils.submitJobToExecutor(dagManagementStateStore, dagNode,
getDagId());
log.info("Submitted job {} for dagId {}",
DagManagerUtils.getJobName(dagNode), getDagId());
}
+
+
DagProcUtils.sendEnforceFlowFinishDeadlineDagAction(dagManagementStateStore,
getDagTask().getDagAction());
Review Comment:
rather than situating here in `submitNextNodes`, this might better belong
within `act()`... in particular shouldn't it only come after this line (from
`act()`):
```
//Checkpoint the dag state, it should have an updated value of dag nodes
dagManagementStateStore.checkpointDag(dag.get());
```
?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
