phet commented on code in PR #3960:
URL: https://github.com/apache/gobblin/pull/3960#discussion_r1623317132
##########
gobblin-service/src/main/java/org/apache/gobblin/service/modules/orchestration/DagManagementTaskStreamImpl.java:
##########
@@ -146,7 +147,7 @@ public DagTask next() {
}
} catch (Exception e) {
//TODO: need to handle exceptions gracefully
- log.error("Exception getting DagAction from the queue / creating
DagTask", e);
+ log.error("Exception getting DagAction from the queue or creating
DagTask. dagAction - {}", dagAction == null ? "<null>" : dagAction, e);
Review Comment:
NBD, but:
```
log.error("Exception getting DagAction from the queue or creating DagTask.
dagAction - {}", dagAction, e);
```
would, when `dagAction == null`, just result in:
```
Exception getting DagAction from the queue or creating DagTask. dagAction -
null
```
which seems simpler to write and not much different than
```
Exception getting DagAction from the queue or creating DagTask. dagAction -
<null>
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
