phet commented on code in PR #3967:
URL: https://github.com/apache/gobblin/pull/3967#discussion_r1631791921
##########
gobblin-runtime/src/main/java/org/apache/gobblin/runtime/api/FlowSpec.java:
##########
@@ -146,14 +150,13 @@ public static FlowSpec.Builder builder(URI catalogURI,
Properties flowProps) {
* @param key
* @param value
*/
- public synchronized void addProperty(String key, String value) {
+ public synchronized void addProperty(String key, Object value) {
Review Comment:
this could obscure errors, beyond merely passing in a `long flowExecId`.
I'd be more comfortable w/ an overloaded `addProperty(String, long)` method -
would that compile and type check?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
