arjun4084346 commented on code in PR #3967:
URL: https://github.com/apache/gobblin/pull/3967#discussion_r1631848470
##########
gobblin-service/src/test/java/org/apache/gobblin/service/modules/orchestration/DagActionReminderSchedulerTest.java:
##########
@@ -29,16 +29,18 @@
import org.testng.Assert;
import org.testng.annotations.Test;
+import com.google.common.base.Joiner;
+
import org.apache.gobblin.configuration.ConfigurationKeys;
public class DagActionReminderSchedulerTest {
String flowGroup = "fg";
String flowName = "fn";
- String flowExecutionId = "123";
+ long flowExecutionId = 123L;
String jobName = "jn";
- String expectedKey = String.join(".", flowGroup, flowName, flowExecutionId,
jobName,
- String.valueOf(DagActionStore.DagActionType.LAUNCH));
+ String expectedKey = Joiner.on("_").join(".", flowGroup, flowName,
flowExecutionId, jobName,
Review Comment:
my bad
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
