[
https://issues.apache.org/jira/browse/GOBBLIN-2017?focusedWorklogId=922904&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-922904
]
ASF GitHub Bot logged work on GOBBLIN-2017:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 11/Jun/24 04:37
Start Date: 11/Jun/24 04:37
Worklog Time Spent: 10m
Work Description: arjun4084346 opened a new pull request, #3965:
URL: https://github.com/apache/gobblin/pull/3965
Dear Gobblin maintainers,
Please accept this PR. I understand that it will not be reviewed until I
have checked off all the steps below!
### JIRA
- [x] My PR addresses the following [Gobblin
JIRA](https://issues.apache.org/jira/browse/GOBBLIN/) issues and references
them in the PR title. For example, "[GOBBLIN-XXX] My Gobblin PR"
- https://issues.apache.org/jira/browse/GOBBLIN-2017
### Description
- [x] Here are some details about my PR, including screenshots (if
applicable):
When there are multiple jobs to run next, DagProcs will write REEVALUATE dag
action for each of the job.
So far, a REEVALUATE dag action assumed that the job is finished and it
would launch the next jobs or cleanup the dag.
That's not the case anymore. Now REEVALUATE dag proc will check the job
status, and if the status is finished, will proceed to launch next jobs or
cleanup the dag. If the job status is not present, it would determine that the
job was never started, and the dag action was created because of parallel jobs,
and it will launch that job.
### Tests
- [x] My PR adds the following unit tests __OR__ does not need testing for
this extremely good reason:
added tests in launchdagproctest and reevaluatedagproctest
### Commits
- [x] My commits all reference JIRA issues in their subject lines, and I
have squashed multiple commits if they address the same issue. In addition, my
commits follow the guidelines from "[How to write a good git commit
message](http://chris.beams.io/posts/git-commit/)":
1. Subject is separated from body by a blank line
2. Subject is limited to 50 characters
3. Subject does not end with a period
4. Subject uses the imperative mood ("add", not "adding")
5. Body wraps at 72 characters
6. Body explains "what" and "why", not "how"
Issue Time Tracking
-------------------
Worklog Id: (was: 922904)
Time Spent: 6h 10m (was: 6h)
> divide multiple job launches in a LaunchDagProc into multiple LaunchDagActions
> ------------------------------------------------------------------------------
>
> Key: GOBBLIN-2017
> URL: https://issues.apache.org/jira/browse/GOBBLIN-2017
> Project: Apache Gobblin
> Issue Type: Task
> Reporter: Arjun Singh Bora
> Priority: Major
> Time Spent: 6h 10m
> Remaining Estimate: 0h
>
> divide multiple job launches in a LaunchDagProc into multiple
> LaunchDagActions for two reasons
> 1) it will then spend less time in each dag proc processing and have more
> chance to complete the operation in the lease time
> 2) handling partial job submissions in one LaunchDagProc sending N jobs is
> difficult
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
