[
https://issues.apache.org/jira/browse/GOBBLIN-2017?focusedWorklogId=922997&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-922997
]
ASF GitHub Bot logged work on GOBBLIN-2017:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 11/Jun/24 17:13
Start Date: 11/Jun/24 17:13
Worklog Time Spent: 10m
Work Description: phet commented on code in PR #3965:
URL: https://github.com/apache/gobblin/pull/3965#discussion_r1635195443
##########
gobblin-service/src/test/java/org/apache/gobblin/service/modules/orchestration/MysqlUserQuotaManagerTest.java:
##########
@@ -135,7 +135,7 @@ public ChangeCountRunnable(boolean increaseOrDecrease) {
public void run() {
int i = 0;
while (i++ < INCREMENTS) {
- try (Connection connection =
MysqlUserQuotaManagerTest.this.quotaManager.quotaStore.dataSource.getConnection();)
{
+ try (Connection connection =
MysqlUserQuotaManagerTest.this.quotaManager.quotaStore.dataSource.getConnection())
{
Review Comment:
is there a difference vs. the one created in `setUp`/`tearDown` and this
one? do we need both? if so, a comment would be very helpful!
##########
.github/workflows/build_and_test.yaml:
##########
@@ -134,6 +134,7 @@ jobs:
sudo dpkg -l | grep -i mysql
sudo apt-get clean
sudo apt-get install -y mysql-client
+ mysql --host 127.0.0.1 --port 3306 -uroot -ppassword -e "SET
GLOBAL max_connections = 2000"
Review Comment:
are you able to tell whether tests are passing due to this increase or
because of better hygiene of closing connections/statements?
Issue Time Tracking
-------------------
Worklog Id: (was: 922997)
Time Spent: 6.5h (was: 6h 20m)
> divide multiple job launches in a LaunchDagProc into multiple LaunchDagActions
> ------------------------------------------------------------------------------
>
> Key: GOBBLIN-2017
> URL: https://issues.apache.org/jira/browse/GOBBLIN-2017
> Project: Apache Gobblin
> Issue Type: Task
> Reporter: Arjun Singh Bora
> Priority: Major
> Time Spent: 6.5h
> Remaining Estimate: 0h
>
> divide multiple job launches in a LaunchDagProc into multiple
> LaunchDagActions for two reasons
> 1) it will then spend less time in each dag proc processing and have more
> chance to complete the operation in the lease time
> 2) handling partial job submissions in one LaunchDagProc sending N jobs is
> difficult
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
