[
https://issues.apache.org/jira/browse/GOBBLIN-2017?focusedWorklogId=923051&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-923051
]
ASF GitHub Bot logged work on GOBBLIN-2017:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 12/Jun/24 00:44
Start Date: 12/Jun/24 00:44
Worklog Time Spent: 10m
Work Description: phet commented on code in PR #3965:
URL: https://github.com/apache/gobblin/pull/3965#discussion_r1635637283
##########
gobblin-metastore/src/test/java/org/apache/gobblin/metastore/testing/TestMetastoreDatabaseServer.java:
##########
@@ -77,6 +79,7 @@ class TestMetastoreDatabaseServer implements Closeable {
private final String dbUserPassword;
private final String dbHost;
private final int dbPort;
+ private static Map<String, Injector> injectors = new HashMap<>();
Review Comment:
I don't understand who's using this. is it basically a per-JDBC-URI mapping
that caches the `Injector`, so it's not created multiple times? a comment
would help here, esp. if there's some nuance as to how caching helps
if so, should this method either be synchronized or we use
`ConcurrentHashMap`?
also, naming could be clearer, such as `injectorsByJdbcUri`
Issue Time Tracking
-------------------
Worklog Id: (was: 923051)
Time Spent: 8h 10m (was: 8h)
> divide multiple job launches in a LaunchDagProc into multiple LaunchDagActions
> ------------------------------------------------------------------------------
>
> Key: GOBBLIN-2017
> URL: https://issues.apache.org/jira/browse/GOBBLIN-2017
> Project: Apache Gobblin
> Issue Type: Task
> Reporter: Arjun Singh Bora
> Priority: Major
> Time Spent: 8h 10m
> Remaining Estimate: 0h
>
> divide multiple job launches in a LaunchDagProc into multiple
> LaunchDagActions for two reasons
> 1) it will then spend less time in each dag proc processing and have more
> chance to complete the operation in the lease time
> 2) handling partial job submissions in one LaunchDagProc sending N jobs is
> difficult
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
