umustafi commented on code in PR #3995:
URL: https://github.com/apache/gobblin/pull/3995#discussion_r1669246118
##########
gobblin-service/src/main/java/org/apache/gobblin/service/monitoring/DagManagementDagActionStoreChangeMonitor.java:
##########
@@ -73,12 +73,14 @@ protected void handleDagAction(String operation,
DagActionStore.DagAction dagAct
break;
case "DELETE":
log.debug("Deleted dagAction from DagActionStore: {}", dagAction);
+ /* TODO: skip deadline removal for now and let them fire
Review Comment:
there's no event time in dagActionStore so cannot remove job from scheduler
& this will be addressed in future pr to handle race condition between creating
and deleting trigger
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
