phet commented on code in PR #3995:
URL: https://github.com/apache/gobblin/pull/3995#discussion_r1669754378
##########
gobblin-service/src/main/java/org/apache/gobblin/service/modules/orchestration/DagActionReminderScheduler.java:
##########
@@ -129,14 +129,18 @@ public void execute(JobExecutionContext context) {
/**
* Creates a key for the reminder job by concatenating all dagAction fields
and the eventTime of the dagAction to
- * allow reminders for actions associated with multiple flow executions
within a deadline period (e.g. another
- * flow execution may occur before a flow finish or job start deadline
expires)
+ * allow reminders for distinct action requests of the same flow execution
within a deadline period (e.g. multiple
+ * kill requests for the same flow execution).
Review Comment:
when you say "deadline period", that's not related to job-start or
flow-completion deadlines, is it? do you mean "reminder period" (approx. the
'linger' setting)?
also, this is when multiple instances of the same action on the same flow
execution originate more than 'epsilon' apart, right? and it's applicable to
only KILL and RESUME, correct?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
