[
https://issues.apache.org/jira/browse/GOBBLIN-2108?focusedWorklogId=925530&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-925530
]
ASF GitHub Bot logged work on GOBBLIN-2108:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 11/Jul/24 20:57
Start Date: 11/Jul/24 20:57
Worklog Time Spent: 10m
Work Description: umustafi commented on code in PR #3998:
URL: https://github.com/apache/gobblin/pull/3998#discussion_r1674683497
##########
gobblin-service/src/main/java/org/apache/gobblin/service/modules/orchestration/DagActionReminderScheduler.java:
##########
@@ -56,19 +59,28 @@
@Slf4j
@Singleton
public class DagActionReminderScheduler {
+ public static final String DAG_ACTION_REMINDER_SCHEDULER_NAME =
"DagActionReminderScheduler";
public static final String RetryReminderKeyGroup = "RetryReminder";
public static final String DeadlineReminderKeyGroup = "DeadlineReminder";
- private final Scheduler quartzScheduler;
Review Comment:
why not private?
##########
gobblin-service/src/test/java/org/apache/gobblin/service/modules/orchestration/DagActionReminderSchedulerTest.java:
##########
@@ -109,4 +115,52 @@ public void testRemindersForMultipleFlowExecutions()
throws SchedulerException {
this.dagActionReminderScheduler.unscheduleReminderJob(launchLeaseParams,
true);
this.dagActionReminderScheduler.unscheduleReminderJob(launchLeaseParams2,
true);
}
+
+ @Test
+ public void testScheduleReminder() throws SchedulerException,
InterruptedException, IOException {
Review Comment:
add comment that ur testing creating of reminder with static method.
Issue Time Tracking
-------------------
Worklog Id: (was: 925530)
Remaining Estimate: 0h
Time Spent: 10m
> fix bug for quartz scheduler instantiate ReminderJob
> ----------------------------------------------------
>
> Key: GOBBLIN-2108
> URL: https://issues.apache.org/jira/browse/GOBBLIN-2108
> Project: Apache Gobblin
> Issue Type: Bug
> Reporter: Arjun Singh Bora
> Priority: Major
> Time Spent: 10m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
