[
https://issues.apache.org/jira/browse/GOBBLIN-2108?focusedWorklogId=925599&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-925599
]
ASF GitHub Bot logged work on GOBBLIN-2108:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 12/Jul/24 06:00
Start Date: 12/Jul/24 06:00
Worklog Time Spent: 10m
Work Description: phet commented on code in PR #3998:
URL: https://github.com/apache/gobblin/pull/3998#discussion_r1675358208
##########
gobblin-service/src/main/java/org/apache/gobblin/service/modules/orchestration/DagActionReminderScheduler.java:
##########
@@ -192,4 +171,44 @@ public static Trigger
createReminderJobTrigger(DagActionStore.LeaseParams leaseP
.startAt(new Date(getCurrentTimeMillis.get() + reminderDurationMillis))
.build();
}
+
+ public class ReminderJobFactory implements JobFactory {
+ @Override
+ public Job newJob(TriggerFiredBundle bundle, Scheduler scheduler) {
+ return new ReminderJob();
+ }
+ }
+
+ /**
+ * Class used to store information regarding a pending dagAction that needs
to be revisited at a later time
+ * by {@link DagManagement} interface to re-attempt a lease on if it has not
been completed by the previous owner.
+ * These jobs are scheduled and used by the {@link
DagActionReminderScheduler}.
+ */
+ public class ReminderJob implements Job {
Review Comment:
I'm not convinced the factory is actually that related to the
`DagActionReminderScheduler`. I was more accepting the compromise that it
would be a way for the latter to "share" its `DagManagement` with the many
`ReminderJob`s. also there's only one factory.
but, TBH, it would be perfectly fine, and IMO preferable if the
`ReminderJobFactory` were static and also held a `private final DagManagement`
(w/ `@RequiredArgsConstructor`), so it could be created as:
```
this.quartzScheduler.setJobFactory(new
ReminderJobFactory(dagManagement));
```
Issue Time Tracking
-------------------
Worklog Id: (was: 925599)
Time Spent: 1h 20m (was: 1h 10m)
> fix bug for quartz scheduler instantiate ReminderJob
> ----------------------------------------------------
>
> Key: GOBBLIN-2108
> URL: https://issues.apache.org/jira/browse/GOBBLIN-2108
> Project: Apache Gobblin
> Issue Type: Bug
> Reporter: Arjun Singh Bora
> Priority: Major
> Time Spent: 1h 20m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
