[
https://issues.apache.org/jira/browse/GOBBLIN-2111?focusedWorklogId=926007&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-926007
]
ASF GitHub Bot logged work on GOBBLIN-2111:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 15/Jul/24 23:18
Start Date: 15/Jul/24 23:18
Worklog Time Spent: 10m
Work Description: Will-Lo commented on code in PR #4002:
URL: https://github.com/apache/gobblin/pull/4002#discussion_r1678495530
##########
gobblin-service/src/test/java/org/apache/gobblin/service/modules/orchestration/proc/LaunchDagProcTest.java:
##########
@@ -135,6 +138,10 @@ public void launchDagWithMultipleParallelJobs() throws
IOException, InterruptedE
flowCompilationValidationHelper);
launchDagProc.process(this.dagManagementStateStore);
+
+ // Verify adhoc flow spec will be removed from catalog
+
Mockito.verify(this.dagManagementStateStore,Mockito.times(2)).removeFlowSpec(any());
Review Comment:
I think this is potentially flaky if you are validating a mock on a shared
object between tests for testng (note Junit should be resetting the mock state
in between tests)
https://stackoverflow.com/questions/37591644/using-mockito-with-testng
To get a consistent behavior you may need to use junit or add this function:
```
@BeforeMethod
public void init() {
MockitoAnnotations.initMocks(this);
}
```
Issue Time Tracking
-------------------
Worklog Id: (was: 926007)
Time Spent: 0.5h (was: 20m)
> Delete adhoc flowSpecs from FlowCatalog for DagProcEngine
> ---------------------------------------------------------
>
> Key: GOBBLIN-2111
> URL: https://issues.apache.org/jira/browse/GOBBLIN-2111
> Project: Apache Gobblin
> Issue Type: Bug
> Components: gobblin-service
> Reporter: Urmi Mustafi
> Assignee: Abhishek Tiwari
> Priority: Major
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> DagProcessingEngine fails to remove adhoc flow specs from catalog after
> checkpointing the dag.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
