[
https://issues.apache.org/jira/browse/GOBBLIN-2111?focusedWorklogId=926265&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-926265
]
ASF GitHub Bot logged work on GOBBLIN-2111:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 17/Jul/24 01:52
Start Date: 17/Jul/24 01:52
Worklog Time Spent: 10m
Work Description: arjun4084346 commented on code in PR #4002:
URL: https://github.com/apache/gobblin/pull/4002#discussion_r1680300699
##########
gobblin-service/src/main/java/org/apache/gobblin/service/modules/orchestration/proc/LaunchDagProc.java:
##########
@@ -69,6 +69,10 @@ protected Optional<Dag<JobExecutionPlan>>
initialize(DagManagementStateStore dag
Optional<Dag<JobExecutionPlan>> dag =
this.flowCompilationValidationHelper.createExecutionPlanIfValid(flowSpec).toJavaUtil();
if (dag.isPresent()) {
dagManagementStateStore.checkpointDag(dag.get());
+ // Delete adhoc flowSpecs from catalog after checkpointing the dag to
be worked on
+ if (!flowSpec.isScheduled()) {
+ dagManagementStateStore.removeFlowSpec(flowSpec);
Review Comment:
Is it the right place to remove flow spec? If the LaunchDagProc act fails, a
second retry will not be able to compile.
should we do it in LaunchDagTask conclude ?
Issue Time Tracking
-------------------
Worklog Id: (was: 926265)
Time Spent: 1h (was: 50m)
> Delete adhoc flowSpecs from FlowCatalog for DagProcEngine
> ---------------------------------------------------------
>
> Key: GOBBLIN-2111
> URL: https://issues.apache.org/jira/browse/GOBBLIN-2111
> Project: Apache Gobblin
> Issue Type: Bug
> Components: gobblin-service
> Reporter: Urmi Mustafi
> Assignee: Abhishek Tiwari
> Priority: Major
> Time Spent: 1h
> Remaining Estimate: 0h
>
> DagProcessingEngine fails to remove adhoc flow specs from catalog after
> checkpointing the dag.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
