[
https://issues.apache.org/jira/browse/GOBBLIN-2117?focusedWorklogId=926937&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-926937
]
ASF GitHub Bot logged work on GOBBLIN-2117:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 22/Jul/24 18:52
Start Date: 22/Jul/24 18:52
Worklog Time Spent: 10m
Work Description: arjun4084346 commented on code in PR #4007:
URL: https://github.com/apache/gobblin/pull/4007#discussion_r1687011456
##########
gobblin-service/src/main/java/org/apache/gobblin/service/modules/orchestration/task/DagProcessingEngineMetrics.java:
##########
@@ -75,6 +75,7 @@ public DagProcessingEngineMetrics() {
List<Tag<?>> tags = new ArrayList<>();
tags.add(new Tag<>(MetricTagNames.METRIC_BACKEND_REPRESENTATION,
GobblinMetrics.MetricType.COUNTER));
this.metricContext = Instrumented.getMetricContext(new State(),
this.getClass(), tags);
+ registerAllMetrics();
Review Comment:
just call `this(this.metricContext)` to use the overloading this class have
Issue Time Tracking
-------------------
Worklog Id: (was: 926937)
Time Spent: 0.5h (was: 20m)
> Initialize metrics map for DagProcEngineMetrics
> -----------------------------------------------
>
> Key: GOBBLIN-2117
> URL: https://issues.apache.org/jira/browse/GOBBLIN-2117
> Project: Apache Gobblin
> Issue Type: Bug
> Components: gobblin-service
> Reporter: Urmi Mustafi
> Assignee: Abhishek Tiwari
> Priority: Major
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> ` No meter exists for dagActionType ENFORCE_JOB_START_DEADLINE in metricsMap
> {}`
> Initialize metrics map for each `dagActionType` in default constructor of
> `DagProcessingEngineMetrics`
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
