[
https://issues.apache.org/jira/browse/GOBBLIN-2117?focusedWorklogId=926954&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-926954
]
ASF GitHub Bot logged work on GOBBLIN-2117:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 22/Jul/24 20:11
Start Date: 22/Jul/24 20:11
Worklog Time Spent: 10m
Work Description: umustafi commented on code in PR #4007:
URL: https://github.com/apache/gobblin/pull/4007#discussion_r1687088785
##########
gobblin-service/src/main/java/org/apache/gobblin/service/modules/orchestration/task/DagProcessingEngineMetrics.java:
##########
@@ -162,6 +167,19 @@ public void
markDagActionsConclude(DagActionStore.DagActionType dagActionType, b
}
}
+ // TODO: mark this metric when deleted
+ public void markDagActionsDeleted(DagActionStore.DagActionType
dagActionType, boolean succeeded) {
Review Comment:
oh this is easier to implement than I initially realized. done
Issue Time Tracking
-------------------
Worklog Id: (was: 926954)
Time Spent: 2h (was: 1h 50m)
> Initialize metrics map for DagProcEngineMetrics
> -----------------------------------------------
>
> Key: GOBBLIN-2117
> URL: https://issues.apache.org/jira/browse/GOBBLIN-2117
> Project: Apache Gobblin
> Issue Type: Bug
> Components: gobblin-service
> Reporter: Urmi Mustafi
> Assignee: Abhishek Tiwari
> Priority: Major
> Time Spent: 2h
> Remaining Estimate: 0h
>
> ` No meter exists for dagActionType ENFORCE_JOB_START_DEADLINE in metricsMap
> {}`
> Initialize metrics map for each `dagActionType` in default constructor of
> `DagProcessingEngineMetrics`
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
