[ 
https://issues.apache.org/jira/browse/GOBBLIN-2121?focusedWorklogId=928353&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-928353
 ]

ASF GitHub Bot logged work on GOBBLIN-2121:
-------------------------------------------

                Author: ASF GitHub Bot
            Created on: 01/Aug/24 20:10
            Start Date: 01/Aug/24 20:10
    Worklog Time Spent: 10m 
      Work Description: arjun4084346 commented on code in PR #4012:
URL: https://github.com/apache/gobblin/pull/4012#discussion_r1700784146


##########
gobblin-service/src/main/java/org/apache/gobblin/service/modules/orchestration/DagActionStore.java:
##########
@@ -33,7 +33,7 @@
  * See javadoc for {@link DagAction}
  */
 public interface DagActionStore {
-  public static final String NO_JOB_NAME_DEFAULT = "";
+  String NO_JOB_NAME_DEFAULT = "";

Review Comment:
   that's not needed for interface. they are always public static





Issue Time Tracking
-------------------

    Worklog Id:     (was: 928353)
    Time Spent: 20m  (was: 10m)

>  redirect kill requests to dag proc engine
> ------------------------------------------
>
>                 Key: GOBBLIN-2121
>                 URL: https://issues.apache.org/jira/browse/GOBBLIN-2121
>             Project: Apache Gobblin
>          Issue Type: Improvement
>            Reporter: Arjun Singh Bora
>            Priority: Major
>          Time Spent: 20m
>  Remaining Estimate: 0h
>




--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to