[
https://issues.apache.org/jira/browse/GOBBLIN-2121?focusedWorklogId=928445&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-928445
]
ASF GitHub Bot logged work on GOBBLIN-2121:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 02/Aug/24 09:45
Start Date: 02/Aug/24 09:45
Worklog Time Spent: 10m
Work Description: phet commented on code in PR #4012:
URL: https://github.com/apache/gobblin/pull/4012#discussion_r1701588762
##########
gobblin-service/src/main/java/org/apache/gobblin/service/modules/orchestration/proc/DeadlineEnforcementDagProc.java:
##########
@@ -68,7 +68,7 @@ protected boolean
isDagStillPresent(Optional<Dag<JobExecutionPlan>> dag, DagMana
if (!dagManagementStateStore.existsJobDagAction(dagAction.getFlowGroup(),
dagAction.getFlowName(),
dagAction.getFlowExecutionId(), dagAction.getJobName(),
dagAction.getDagActionType())) {
- log.warn("Dag action {} is cleaned up from DMSS. No further action is
required.", dagAction);
+ log.info("Dag action {} is cleaned up from DMSS. No further action is
required.", dagAction);
return false;
Review Comment:
don't we already hold a lease by the time `act` is called? if so, it would
be exceedingly rare (and really no different than any other `DagProc::act`
derived class impl). given the rarity, I'd suggest to remove.
but if we really believe we need this, let's observe the commonality by
placing this impl within the `DagProc` base class
Issue Time Tracking
-------------------
Worklog Id: (was: 928445)
Time Spent: 2h 10m (was: 2h)
> redirect kill requests to dag proc engine
> ------------------------------------------
>
> Key: GOBBLIN-2121
> URL: https://issues.apache.org/jira/browse/GOBBLIN-2121
> Project: Apache Gobblin
> Issue Type: Improvement
> Reporter: Arjun Singh Bora
> Priority: Major
> Time Spent: 2h 10m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
