phet commented on code in PR #4012:
URL: https://github.com/apache/gobblin/pull/4012#discussion_r1701588762
##########
gobblin-service/src/main/java/org/apache/gobblin/service/modules/orchestration/proc/DeadlineEnforcementDagProc.java:
##########
@@ -68,7 +68,7 @@ protected boolean
isDagStillPresent(Optional<Dag<JobExecutionPlan>> dag, DagMana
if (!dagManagementStateStore.existsJobDagAction(dagAction.getFlowGroup(),
dagAction.getFlowName(),
dagAction.getFlowExecutionId(), dagAction.getJobName(),
dagAction.getDagActionType())) {
- log.warn("Dag action {} is cleaned up from DMSS. No further action is
required.", dagAction);
+ log.info("Dag action {} is cleaned up from DMSS. No further action is
required.", dagAction);
return false;
Review Comment:
don't we already hold a lease by the time `act` is called? if so, it would
be exceedingly rare (and really no different than any other `DagProc::act`
derived class impl). given the rarity, I'd suggest to remove.
but if we really believe we need this, let's observe the commonality by
placing this impl within the `DagProc` base class
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
