arjun4084346 commented on code in PR #4015:
URL: https://github.com/apache/gobblin/pull/4015#discussion_r1702280841
##########
gobblin-service/src/main/java/org/apache/gobblin/service/modules/orchestration/proc/DeadlineEnforcementDagProc.java:
##########
@@ -48,16 +48,16 @@ protected Optional<Dag<JobExecutionPlan>>
initialize(DagManagementStateStore dag
@Override
protected void act(DagManagementStateStore dagManagementStateStore,
Optional<Dag<JobExecutionPlan>> dag,
DagProcessingEngineMetrics dagProcEngineMetrics) throws IOException {
+ log.info("Request to enforce {} deadline for dag {}", getDagActionType(),
getDagId());
if (isDagStillPresent(dag, dagManagementStateStore)) {
+ // if the job is not already completed and dag action is still present,
enforce deadline
enforceDeadline(dagManagementStateStore, dag.get(),
dagProcEngineMetrics);
- } else {
- dagProcEngineMetrics.markDagActionsAct(getDagActionType(), false);
- }
+ }
+ dagProcEngineMetrics.markDagActionsAct(getDagActionType(), true);
Review Comment:
returning true, because this is not a failure in dagActionAct
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
