phet commented on code in PR #4013:
URL: https://github.com/apache/gobblin/pull/4013#discussion_r1701616940
##########
gobblin-runtime/src/main/java/org/apache/gobblin/service/monitoring/FlowStatusGenerator.java:
##########
@@ -41,7 +41,7 @@
@Slf4j
public class FlowStatusGenerator {
public static final List<String> FINISHED_STATUSES =
Lists.newArrayList(ExecutionStatus.FAILED.name(),
- ExecutionStatus.COMPLETE.name(), ExecutionStatus.CANCELLED.name());
+ ExecutionStatus.COMPLETE.name(), ExecutionStatus.CANCELLED.name(),
ExecutionStatus.PENDING_RETRY.name());
Review Comment:
this is used in a number of places. is it acceptable to change the semantics
for all of them? e.g. is it OK here in `MysqlDMStateStore`:
```
public boolean hasRunningJobs(DagManager.DagId dagId) throws IOException {
return getDagNodes(dagId).stream()
.anyMatch(node ->
!FlowStatusGenerator.FINISHED_STATUSES.contains(node.getValue().getExecutionStatus().name()));
}
```
?
couldn't it lead to this in `DagManager`:
```
default:
log.warn("Unexpected flow event {} for dag {}",
dag.getFlowEvent(), dagId);
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
