[
https://issues.apache.org/jira/browse/GOBBLIN-2124?focusedWorklogId=928773&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-928773
]
ASF GitHub Bot logged work on GOBBLIN-2124:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 05/Aug/24 20:48
Start Date: 05/Aug/24 20:48
Worklog Time Spent: 10m
Work Description: arjun4084346 commented on code in PR #4016:
URL: https://github.com/apache/gobblin/pull/4016#discussion_r1704617001
##########
gobblin-service/src/main/java/org/apache/gobblin/service/modules/orchestration/proc/DagProc.java:
##########
@@ -55,14 +62,23 @@ public abstract class DagProc<T> {
@Getter protected final DagManager.DagId dagId;
@Getter protected final DagNodeId dagNodeId;
protected static final MetricContext metricContext =
Instrumented.getMetricContext(new State(), DagProc.class);
+ protected final List<Class<? extends Exception>> nonRetryableExceptions;
protected static final EventSubmitter eventSubmitter = new
EventSubmitter.Builder(
metricContext, "org.apache.gobblin.service").build();
- public DagProc(DagTask dagTask) {
+ public DagProc(DagTask dagTask, Config config) {
this.dagTask = dagTask;
this.dagId =
DagManagerUtils.generateDagId(this.dagTask.getDagAction().getFlowGroup(),
this.dagTask.getDagAction().getFlowName(),
this.dagTask.getDagAction().getFlowExecutionId());
this.dagNodeId = this.dagTask.getDagAction().getDagNodeId();
+ this.nonRetryableExceptions = ConfigUtils.getStringList(config,
ServiceConfigKeys.DAG_PROC_ENGINE_NON_RETRYABLE_EXCEPTIONS_KEY)
Review Comment:
ConfigUtils.getStringList returns Collections.emptyList() if config is not
present
Issue Time Tracking
-------------------
Worklog Id: (was: 928773)
Time Spent: 1.5h (was: 1h 20m)
> ignore non-retryable exceptions in dag proc engine
> --------------------------------------------------
>
> Key: GOBBLIN-2124
> URL: https://issues.apache.org/jira/browse/GOBBLIN-2124
> Project: Apache Gobblin
> Issue Type: Improvement
> Reporter: Arjun Singh Bora
> Priority: Major
> Time Spent: 1.5h
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
