[
https://issues.apache.org/jira/browse/GOBBLIN-2124?focusedWorklogId=928777&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-928777
]
ASF GitHub Bot logged work on GOBBLIN-2124:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 05/Aug/24 21:28
Start Date: 05/Aug/24 21:28
Worklog Time Spent: 10m
Work Description: umustafi commented on code in PR #4016:
URL: https://github.com/apache/gobblin/pull/4016#discussion_r1704647883
##########
gobblin-service/src/main/java/org/apache/gobblin/service/monitoring/KafkaJobStatusMonitor.java:
##########
@@ -236,7 +237,7 @@ protected void
processMessage(DecodeableKafkaRecord<byte[],byte[]> message) {
try {
this.dagManagementStateStore.addJobDagAction(flowGroup,
flowName, flowExecutionId, jobName, DagActionStore.DagActionType.REEVALUATE);
} catch (IOException e) {
- if (e.getCause() != null &&
isThrowableInstanceOf(e.getCause(), nonRetryableExceptions)) {
+ if (ExceptionUtils.isExceptionInstanceOf(e,
nonRetryableExceptions)) {
Review Comment:
here we only create duplicate REEVALUATE for transient so it should be
`!ExceptionUtils.isExceptionInstanceOf` then we create another action. Can you
also add a metric here to `DagProcessingEngineMetrics`?
Issue Time Tracking
-------------------
Worklog Id: (was: 928777)
Time Spent: 1h 50m (was: 1h 40m)
> ignore non-retryable exceptions in dag proc engine
> --------------------------------------------------
>
> Key: GOBBLIN-2124
> URL: https://issues.apache.org/jira/browse/GOBBLIN-2124
> Project: Apache Gobblin
> Issue Type: Improvement
> Reporter: Arjun Singh Bora
> Priority: Major
> Time Spent: 1h 50m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
